@vibe-reporting/redis-connect@1.0.15
Vulnerabilities |
15 via 21 paths |
---|---|
Dependencies |
458 |
Source |
npm |
Find, fix and prevent vulnerabilities in your code.
high severity
- Vulnerable module: bl
- Introduced through: @vibe-reporting/core@1.2.5
Detailed paths
-
Introduced through: @vibe-reporting/redis-connect@1.0.15 › @vibe-reporting/core@1.2.5 › redbird@0.7.0 › node-etcd@4.2.1 › request@2.60.0 › bl@1.0.3
Overview
bl is a library that allows you to collect buffers and access with a standard readable buffer interface.
Affected versions of this package are vulnerable to Remote Memory Exposure. If user input ends up in consume()
argument and can become negative, BufferList state can be corrupted, tricking it into exposing uninitialized memory via regular .slice()
calls.
PoC by chalker
const { BufferList } = require('bl')
const secret = require('crypto').randomBytes(256)
for (let i = 0; i < 1e6; i++) {
const clone = Buffer.from(secret)
const bl = new BufferList()
bl.append(Buffer.from('a'))
bl.consume(-1024)
const buf = bl.slice(1)
if (buf.indexOf(clone) !== -1) {
console.error(`Match (at ${i})`, buf)
}
}
Remediation
Upgrade bl
to version 2.2.1, 3.0.1, 4.0.3, 1.2.3 or higher.
References
high severity
- Vulnerable module: bson
- Introduced through: @vibe-reporting/core@1.2.5
Detailed paths
-
Introduced through: @vibe-reporting/redis-connect@1.0.15 › @vibe-reporting/core@1.2.5 › mongodb@3.0.8 › mongodb-core@3.0.8 › bson@1.0.9
Overview
bson is a BSON Parser for node and browser.
Affected versions of this package are vulnerable to Internal Property Tampering. The package will ignore an unknown value for an object's _bsotype
, leading to cases where an object is serialized as a document rather than the intended BSON type.
Remediation
Upgrade bson
to version 1.1.4 or higher.
References
high severity
- Vulnerable module: engine.io
- Introduced through: @vibe-reporting/core@1.2.5
Detailed paths
-
Introduced through: @vibe-reporting/redis-connect@1.0.15 › @vibe-reporting/core@1.2.5 › socket.io@2.4.1 › engine.io@3.5.0
Overview
engine.io is a realtime engine behind Socket.IO. It provides the foundation of a bidirectional connection between client and server
Affected versions of this package are vulnerable to Denial of Service (DoS) via a POST request to the long polling transport.
Details
Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its intended and legitimate users.
Unlike other vulnerabilities, DoS attacks usually do not aim at breaching security. Rather, they are focused on making websites and services unavailable to genuine users resulting in downtime.
One popular Denial of Service vulnerability is DDoS (a Distributed Denial of Service), an attack that attempts to clog network pipes to the system by generating a large volume of traffic from many machines.
When it comes to open source libraries, DoS vulnerabilities allow attackers to trigger such a crash or crippling of the service by using a flaw either in the application code or from the use of open source libraries.
Two common types of DoS vulnerabilities:
High CPU/Memory Consumption- An attacker sending crafted requests that could cause the system to take a disproportionate amount of time to process. For example, commons-fileupload:commons-fileupload.
Crash - An attacker sending crafted requests that could cause the system to crash. For Example, npm
ws
package
Remediation
Upgrade engine.io
to version 4.0.0 or higher.
References
high severity
- Vulnerable module: mongodb
- Introduced through: @vibe-reporting/core@1.2.5
Detailed paths
-
Introduced through: @vibe-reporting/redis-connect@1.0.15 › @vibe-reporting/core@1.2.5 › mongodb@3.0.8
Overview
mongodb is an official MongoDB driver for Node.js.
Affected versions of this package are vulnerable to Denial of Service (DoS). The package fails to properly catch an exception when a collection name is invalid and the DB does not exist, crashing the application.
Details
Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.
The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.
Let’s take the following regular expression as an example:
regex = /A(B|C+)+D/
This regular expression accomplishes the following:
A
The string must start with the letter 'A'(B|C+)+
The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the+
matches one or more times). The+
at the end of this section states that we can look for one or more matches of this section.D
Finally, we ensure this section of the string ends with a 'D'
The expression would match inputs such as ABBD
, ABCCCCD
, ABCBCCCD
and ACCCCCD
It most cases, it doesn't take very long for a regex engine to find a match:
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total
The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.
Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.
Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:
- CCC
- CC+C
- C+CC
- C+C+C.
The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.
From there, the number of steps the engine must use to validate a string just continues to grow.
String | Number of C's | Number of steps |
---|---|---|
ACCCX | 3 | 38 |
ACCCCX | 4 | 71 |
ACCCCCX | 5 | 136 |
ACCCCCCCCCCCCCCX | 14 | 65,553 |
By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.
Remediation
Upgrade mongodb
to version 3.1.13 or higher.
References
high severity
- Vulnerable module: node-forge
- Introduced through: @vibe-reporting/core@1.2.5
Detailed paths
-
Introduced through: @vibe-reporting/redis-connect@1.0.15 › @vibe-reporting/core@1.2.5 › redbird@0.7.0 › letsencrypt@2.1.10 › rsa-compat@1.9.4 › node-forge@0.7.6
-
Introduced through: @vibe-reporting/redis-connect@1.0.15 › @vibe-reporting/core@1.2.5 › redbird@0.7.0 › letsencrypt@2.1.10 › le-acme-core@2.1.4 › rsa-compat@1.9.4 › node-forge@0.7.6
-
Introduced through: @vibe-reporting/redis-connect@1.0.15 › @vibe-reporting/core@1.2.5 › redbird@0.7.0 › letsencrypt@2.1.10 › le-challenge-sni@2.0.1 › le-tls-sni@0.1.4 › rsa-compat@1.9.4 › node-forge@0.7.6
-
Introduced through: @vibe-reporting/redis-connect@1.0.15 › @vibe-reporting/core@1.2.5 › redbird@0.7.0 › letsencrypt@2.1.10 › le-challenge-sni@2.0.1 › le-tls-sni@0.1.4 › node-forge@0.6.49
Overview
node-forge is a JavaScript implementations of network transports, cryptography, ciphers, PKI, message digests, and various utilities.
Affected versions of this package are vulnerable to Prototype Pollution via the util.setPath
function.
Note: version 0.10.0 is a breaking change removing the vulnerable functions.
POC:
const nodeforge = require('node-forge');
var obj = {};
nodeforge.util.setPath(obj, ['__proto__', 'polluted'], true);
console.log(polluted);
Details
Prototype Pollution is a vulnerability affecting JavaScript. Prototype Pollution refers to the ability to inject properties into existing JavaScript language construct prototypes, such as objects. JavaScript allows all Object attributes to be altered, including their magical attributes such as _proto_
, constructor
and prototype
. An attacker manipulates these attributes to overwrite, or pollute, a JavaScript application object prototype of the base object by injecting other values. Properties on the Object.prototype
are then inherited by all the JavaScript objects through the prototype chain. When that happens, this leads to either denial of service by triggering JavaScript exceptions, or it tampers with the application source code to force the code path that the attacker injects, thereby leading to remote code execution.
There are two main ways in which the pollution of prototypes occurs:
- Unsafe
Object
recursive merge - Property definition by path
Unsafe Object recursive merge
The logic of a vulnerable recursive merge function follows the following high-level model:
merge (target, source)
foreach property of source
if property exists and is an object on both the target and the source
merge(target[property], source[property])
else
target[property] = source[property]
When the source object contains a property named _proto_
defined with Object.defineProperty()
, the condition that checks if the property exists and is an object on both the target and the source passes and the merge recurses with the target, being the prototype of Object
and the source of Object
as defined by the attacker. Properties are then copied on the Object
prototype.
Clone operations are a special sub-class of unsafe recursive merges, which occur when a recursive merge is conducted on an empty object: merge({},source)
.
lodash
and Hoek
are examples of libraries susceptible to recursive merge attacks.
Property definition by path
There are a few JavaScript libraries that use an API to define property values on an object based on a given path. The function that is generally affected contains this signature: theFunction(object, path, value)
If the attacker can control the value of “path”, they can set this value to _proto_.myValue
. myValue
is then assigned to the prototype of the class of the object.
Types of attacks
There are a few methods by which Prototype Pollution can be manipulated:
Type | Origin | Short description |
---|---|---|
Denial of service (DoS) | Client | This is the most likely attack. DoS occurs when Object holds generic functions that are implicitly called for various operations (for example, toString and valueOf ). The attacker pollutes Object.prototype.someattr and alters its state to an unexpected value such as Int or Object . In this case, the code fails and is likely to cause a denial of service. For example: if an attacker pollutes Object.prototype.toString by defining it as an integer, if the codebase at any point was reliant on someobject.toString() it would fail. |
Remote Code Execution | Client | Remote code execution is generally only possible in cases where the codebase evaluates a specific attribute of an object, and then executes that evaluation. For example: eval(someobject.someattr) . In this case, if the attacker pollutes Object.prototype.someattr they are likely to be able to leverage this in order to execute code. |
Property Injection | Client | The attacker pollutes properties that the codebase relies on for their informative value, including security properties such as cookies or tokens. For example: if a codebase checks privileges for someuser.isAdmin , then when the attacker pollutes Object.prototype.isAdmin and sets it to equal true , they can then achieve admin privileges. |
Affected environments
The following environments are susceptible to a Prototype Pollution attack:
- Application server
- Web server
How to prevent
- Freeze the prototype— use
Object.freeze (Object.prototype)
. - Require schema validation of JSON input.
- Avoid using unsafe recursive merge functions.
- Consider using objects without prototypes (for example,
Object.create(null)
), breaking the prototype chain and preventing pollution. - As a best practice use
Map
instead ofObject
.
For more information on this vulnerability type:
Arteau, Oliver. “JavaScript prototype pollution attack in NodeJS application.” GitHub, 26 May 2018
Remediation
Upgrade node-forge
to version 0.10.0 or higher.
References
high severity
- Vulnerable module: qs
- Introduced through: @vibe-reporting/core@1.2.5
Detailed paths
-
Introduced through: @vibe-reporting/redis-connect@1.0.15 › @vibe-reporting/core@1.2.5 › redbird@0.7.0 › node-etcd@4.2.1 › request@2.60.0 › qs@4.0.0
Overview
qs is a querystring parser that supports nesting and arrays, with a depth limit.
Affected versions of this package are vulnerable to Prototype Override Protection Bypass. By default qs
protects against attacks that attempt to overwrite an object's existing prototype properties, such as toString()
, hasOwnProperty()
,etc.
From qs
documentation:
By default parameters that would overwrite properties on the object prototype are ignored, if you wish to keep the data from those fields either use plainObjects as mentioned above, or set allowPrototypes to true which will allow user input to overwrite those properties. WARNING It is generally a bad idea to enable this option as it can cause problems when attempting to use the properties that have been overwritten. Always be careful with this option.
Overwriting these properties can impact application logic, potentially allowing attackers to work around security controls, modify data, make the application unstable and more.
In versions of the package affected by this vulnerability, it is possible to circumvent this protection and overwrite prototype properties and functions by prefixing the name of the parameter with [
or ]
. e.g. qs.parse("]=toString")
will return {toString = true}
, as a result, calling toString()
on the object will throw an exception.
Example:
qs.parse('toString=foo', { allowPrototypes: false })
// {}
qs.parse("]=toString", { allowPrototypes: false })
// {toString = true} <== prototype overwritten
For more information, you can check out our blog.
Disclosure Timeline
- February 13th, 2017 - Reported the issue to package owner.
- February 13th, 2017 - Issue acknowledged by package owner.
- February 16th, 2017 - Partial fix released in versions
6.0.3
,6.1.1
,6.2.2
,6.3.1
. - March 6th, 2017 - Final fix released in versions
6.4.0
,6.3.2
,6.2.3
,6.1.2
and6.0.4
Remediation
Upgradeqs
to version 6.0.4, 6.1.2, 6.2.3, 6.3.2 or higher.References
- GitHub Commit
- GitHub Issue
medium severity
- Vulnerable module: fastify
- Introduced through: @vibe-reporting/core@1.2.5
Detailed paths
-
Introduced through: @vibe-reporting/redis-connect@1.0.15 › @vibe-reporting/core@1.2.5 › fastify@1.14.6
Overview
fastify is an overhead web framework, for Node.js.
Affected versions of this package are vulnerable to Denial of Service (DoS). A denial of service vulnerability exists in Fastify v2.14.1 and v3.0.0-rc.4 that allows A malicious user can trigger resource exhaustion (when the allErrors option is used) with specially crafted schemas.
Details
Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its intended and legitimate users.
Unlike other vulnerabilities, DoS attacks usually do not aim at breaching security. Rather, they are focused on making websites and services unavailable to genuine users resulting in downtime.
One popular Denial of Service vulnerability is DDoS (a Distributed Denial of Service), an attack that attempts to clog network pipes to the system by generating a large volume of traffic from many machines.
When it comes to open source libraries, DoS vulnerabilities allow attackers to trigger such a crash or crippling of the service by using a flaw either in the application code or from the use of open source libraries.
Two common types of DoS vulnerabilities:
High CPU/Memory Consumption- An attacker sending crafted requests that could cause the system to take a disproportionate amount of time to process. For example, commons-fileupload:commons-fileupload.
Crash - An attacker sending crafted requests that could cause the system to crash. For Example, npm
ws
package
Remediation
Upgrade fastify
to version 2.15.1 or higher.
References
medium severity
- Vulnerable module: find-my-way
- Introduced through: @vibe-reporting/core@1.2.5
Detailed paths
-
Introduced through: @vibe-reporting/redis-connect@1.0.15 › @vibe-reporting/core@1.2.5 › fastify@1.14.6 › find-my-way@1.18.1
Overview
Affected versions of this package are vulnerable to Web Cache Poisoning. It accepts the Accept-Version
header by default, and if versioned routes are not being used, this could lead to a denial of service. Accept-Version
can be used as an unkeyed header in a cache poisoning attack.
Remediation
Upgrade find-my-way
to version 2.2.5, 3.0.5 or higher.
References
medium severity
- Vulnerable module: glob-parent
- Introduced through: @vibe-reporting/core@1.2.5
Detailed paths
-
Introduced through: @vibe-reporting/redis-connect@1.0.15 › @vibe-reporting/core@1.2.5 › mqtt@2.18.8 › help-me@1.1.0 › glob-stream@6.1.0 › glob-parent@3.1.0
Overview
glob-parent is a package that helps extracting the non-magic parent path from a glob string.
Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS). The enclosure
regex used to check for strings ending in enclosure containing path separator.
PoC by Yeting Li
var globParent = require("glob-parent")
function build_attack(n) {
var ret = "{"
for (var i = 0; i < n; i++) {
ret += "/"
}
return ret;
}
globParent(build_attack(5000));
Details
Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.
The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.
Let’s take the following regular expression as an example:
regex = /A(B|C+)+D/
This regular expression accomplishes the following:
A
The string must start with the letter 'A'(B|C+)+
The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the+
matches one or more times). The+
at the end of this section states that we can look for one or more matches of this section.D
Finally, we ensure this section of the string ends with a 'D'
The expression would match inputs such as ABBD
, ABCCCCD
, ABCBCCCD
and ACCCCCD
It most cases, it doesn't take very long for a regex engine to find a match:
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total
The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.
Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.
Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:
- CCC
- CC+C
- C+CC
- C+C+C.
The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.
From there, the number of steps the engine must use to validate a string just continues to grow.
String | Number of C's | Number of steps |
---|---|---|
ACCCX | 3 | 38 |
ACCCCX | 4 | 71 |
ACCCCCX | 5 | 136 |
ACCCCCCCCCCCCCCX | 14 | 65,553 |
By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.
Remediation
There is no fixed version for glob-parent
.
References
medium severity
- Vulnerable module: hoek
- Introduced through: @vibe-reporting/core@1.2.5
Detailed paths
-
Introduced through: @vibe-reporting/redis-connect@1.0.15 › @vibe-reporting/core@1.2.5 › redbird@0.7.0 › node-etcd@4.2.1 › request@2.60.0 › hawk@3.1.3 › hoek@2.16.3Remediation: Open PR to patch hoek@2.16.3.
-
Introduced through: @vibe-reporting/redis-connect@1.0.15 › @vibe-reporting/core@1.2.5 › redbird@0.7.0 › node-etcd@4.2.1 › request@2.60.0 › hawk@3.1.3 › boom@2.10.1 › hoek@2.16.3Remediation: Open PR to patch hoek@2.16.3.
-
Introduced through: @vibe-reporting/redis-connect@1.0.15 › @vibe-reporting/core@1.2.5 › redbird@0.7.0 › node-etcd@4.2.1 › request@2.60.0 › hawk@3.1.3 › sntp@1.0.9 › hoek@2.16.3Remediation: Open PR to patch hoek@2.16.3.
-
Introduced through: @vibe-reporting/redis-connect@1.0.15 › @vibe-reporting/core@1.2.5 › redbird@0.7.0 › node-etcd@4.2.1 › request@2.60.0 › hawk@3.1.3 › cryptiles@2.0.5 › boom@2.10.1 › hoek@2.16.3Remediation: Open PR to patch hoek@2.16.3.
Overview
hoek is an Utility methods for the hapi ecosystem.
Affected versions of this package are vulnerable to Prototype Pollution. The utilities function allow modification of the Object
prototype. If an attacker can control part of the structure passed to this function, they could add or modify an existing property.
PoC by Olivier Arteau (HoLyVieR)
var Hoek = require('hoek');
var malicious_payload = '{"__proto__":{"oops":"It works !"}}';
var a = {};
console.log("Before : " + a.oops);
Hoek.merge({}, JSON.parse(malicious_payload));
console.log("After : " + a.oops);
Details
Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.
The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.
Let’s take the following regular expression as an example:
regex = /A(B|C+)+D/
This regular expression accomplishes the following:
A
The string must start with the letter 'A'(B|C+)+
The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the+
matches one or more times). The+
at the end of this section states that we can look for one or more matches of this section.D
Finally, we ensure this section of the string ends with a 'D'
The expression would match inputs such as ABBD
, ABCCCCD
, ABCBCCCD
and ACCCCCD
It most cases, it doesn't take very long for a regex engine to find a match:
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total
The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.
Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.
Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:
- CCC
- CC+C
- C+CC
- C+C+C.
The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.
From there, the number of steps the engine must use to validate a string just continues to grow.
String | Number of C's | Number of steps |
---|---|---|
ACCCX | 3 | 38 |
ACCCCX | 4 | 71 |
ACCCCCX | 5 | 136 |
ACCCCCCCCCCCCCCX | 14 | 65,553 |
By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.
Remediation
Upgrade hoek
to version 4.2.1, 5.0.3 or higher.
References
medium severity
- Vulnerable module: http-signature
- Introduced through: @vibe-reporting/core@1.2.5
Detailed paths
-
Introduced through: @vibe-reporting/redis-connect@1.0.15 › @vibe-reporting/core@1.2.5 › redbird@0.7.0 › node-etcd@4.2.1 › request@2.60.0 › http-signature@0.11.0
Overview
http-signature
is a reference implementation of Joyent's HTTP Signature scheme.
Affected versions of the package are vulnerable to Timing Attacks due to time-variable comparison of signatures.
The library implemented a character to character comparison, similar to the built-in string comparison mechanism, ===
, and not a time constant string comparison. As a result, the comparison will fail faster when the first characters in the signature are incorrect.
An attacker can use this difference to perform a timing attack, essentially allowing them to guess the signature one character at a time.
You can read more about timing attacks in Node.js on the Snyk blog.
Remediation
Upgrade http-signature
to version 1.0.0 or higher.
References
medium severity
- Vulnerable module: node-forge
- Introduced through: @vibe-reporting/core@1.2.5
Detailed paths
-
Introduced through: @vibe-reporting/redis-connect@1.0.15 › @vibe-reporting/core@1.2.5 › redbird@0.7.0 › letsencrypt@2.1.10 › le-challenge-sni@2.0.1 › le-tls-sni@0.1.4 › node-forge@0.6.49
Overview
node-forge
is a native implementation of TLS (and various other cryptographic tools) in JavaScript.
Affected versions of this package are vulnerable to Regular Expression Denial of Service (ReDoS) attacks. This can cause an impact of about 10 seconds matching time for data 3K characters long.
Disclosure Timeline
- Feb 15th, 2018 - Initial Disclosure to package owner
- Feb 15th, 2018 - Initial Response by package owner
- Feb 15th, 2018 - GitHub issue opened
- Feb 26th, 2018 - Vulnerability published
- Mar 7thth, 2018 - Vulnerability fixed
Details
Denial of Service (DoS) describes a family of attacks, all aimed at making a system inaccessible to its original and legitimate users. There are many types of DoS attacks, ranging from trying to clog the network pipes to the system by generating a large volume of traffic from many machines (a Distributed Denial of Service - DDoS - attack) to sending crafted requests that cause a system to crash or take a disproportional amount of time to process.
The Regular expression Denial of Service (ReDoS) is a type of Denial of Service attack. Regular expressions are incredibly powerful, but they aren't very intuitive and can ultimately end up making it easy for attackers to take your site down.
Let’s take the following regular expression as an example:
regex = /A(B|C+)+D/
This regular expression accomplishes the following:
A
The string must start with the letter 'A'(B|C+)+
The string must then follow the letter A with either the letter 'B' or some number of occurrences of the letter 'C' (the+
matches one or more times). The+
at the end of this section states that we can look for one or more matches of this section.D
Finally, we ensure this section of the string ends with a 'D'
The expression would match inputs such as ABBD
, ABCCCCD
, ABCBCCCD
and ACCCCCD
It most cases, it doesn't take very long for a regex engine to find a match:
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCD")'
0.04s user 0.01s system 95% cpu 0.052 total
$ time node -e '/A(B|C+)+D/.test("ACCCCCCCCCCCCCCCCCCCCCCCCCCCCX")'
1.79s user 0.02s system 99% cpu 1.812 total
The entire process of testing it against a 30 characters long string takes around ~52ms. But when given an invalid string, it takes nearly two seconds to complete the test, over ten times as long as it took to test a valid string. The dramatic difference is due to the way regular expressions get evaluated.
Most Regex engines will work very similarly (with minor differences). The engine will match the first possible way to accept the current character and proceed to the next one. If it then fails to match the next one, it will backtrack and see if there was another way to digest the previous character. If it goes too far down the rabbit hole only to find out the string doesn’t match in the end, and if many characters have multiple valid regex paths, the number of backtracking steps can become very large, resulting in what is known as catastrophic backtracking.
Let's look at how our expression runs into this problem, using a shorter string: "ACCCX". While it seems fairly straightforward, there are still four different ways that the engine could match those three C's:
- CCC
- CC+C
- C+CC
- C+C+C.
The engine has to try each of those combinations to see if any of them potentially match against the expression. When you combine that with the other steps the engine must take, we can use RegEx 101 debugger to see the engine has to take a total of 38 steps before it can determine the string doesn't match.
From there, the number of steps the engine must use to validate a string just continues to grow.
String | Number of C's | Number of steps |
---|---|---|
ACCCX | 3 | 38 |
ACCCCX | 4 | 71 |
ACCCCCX | 5 | 136 |
ACCCCCCCCCCCCCCX | 14 | 65,553 |
By the time the string includes 14 C's, the engine has to take over 65,000 steps just to see if the string is valid. These extreme situations can cause them to work very slowly (exponentially related to input size, as shown above), allowing an attacker to exploit this and can cause the service to excessively consume CPU, resulting in a Denial of Service.
Remediation
Update node-forge
to version 0.7.4 or higher.
References
medium severity
- Vulnerable module: redbird
- Introduced through: @vibe-reporting/core@1.2.5
Detailed paths
-
Introduced through: @vibe-reporting/redis-connect@1.0.15 › @vibe-reporting/core@1.2.5 › redbird@0.7.0
Overview
redbird is a complete library to build dynamic reverse proxies with the speed and robustness of http-proxy.
Affected versions of this package are vulnerable to Insufficient Validation. There is no option in lib/proxy.js
which would allow for disabling TLS1.0 connections, which are considered to be vulnerable and deprecated.
Remediation
Upgrade redbird
to version 0.9.1 or higher.
References
medium severity
- Vulnerable module: request
- Introduced through: @vibe-reporting/core@1.2.5
Detailed paths
-
Introduced through: @vibe-reporting/redis-connect@1.0.15 › @vibe-reporting/core@1.2.5 › redbird@0.7.0 › node-etcd@4.2.1 › request@2.60.0Remediation: Open PR to patch request@2.60.0.
Overview
request is a simplified http request client.
Affected versions of this package are vulnerable to Remote Memory Exposure.
A potential remote memory exposure vulnerability exists in request
. If a request
uses a multipart attachment and the body type option is number
with value X, then X bytes of uninitialized memory will be sent in the body of the request.
Note that while the impact of this vulnerability is high (memory exposure), exploiting it is likely difficult, as the attacker needs to somehow control the body type of the request. One potential exploit scenario is when a request is composed based on JSON input, including the body type, allowing a malicious JSON to trigger the memory leak.
Details
Constructing a Buffer
class with integer N
creates a Buffer
of length N
with non zero-ed out memory.
Example:
var x = new Buffer(100); // uninitialized Buffer of length 100
// vs
var x = new Buffer('100'); // initialized Buffer with value of '100'
Initializing a multipart body in such manner will cause uninitialized memory to be sent in the body of the request.
Proof of concept
var http = require('http')
var request = require('request')
http.createServer(function (req, res) {
var data = ''
req.setEncoding('utf8')
req.on('data', function (chunk) {
console.log('data')
data += chunk
})
req.on('end', function () {
// this will print uninitialized memory from the client
console.log('Client sent:\n', data)
})
res.end()
}).listen(8000)
request({
method: 'POST',
uri: 'http://localhost:8000',
multipart: [{ body: 1000 }]
},
function (err, res, body) {
if (err) return console.error('upload failed:', err)
console.log('sent')
})
Remediation
Upgrade request
to version 2.68.0 or higher.
References
medium severity
- Vulnerable module: tunnel-agent
- Introduced through: @vibe-reporting/core@1.2.5
Detailed paths
-
Introduced through: @vibe-reporting/redis-connect@1.0.15 › @vibe-reporting/core@1.2.5 › redbird@0.7.0 › node-etcd@4.2.1 › request@2.60.0 › tunnel-agent@0.4.3Remediation: Open PR to patch tunnel-agent@0.4.3.
Overview
tunnel-agent
is HTTP proxy tunneling agent. Affected versions of the package are vulnerable to Uninitialized Memory Exposure.
A possible memory disclosure vulnerability exists when a value of type number
is used to set the proxy.auth option of a request request
and results in a possible uninitialized memory exposures in the request body.
This is a result of unobstructed use of the Buffer
constructor, whose insecure default constructor increases the odds of memory leakage.
Details
Constructing a Buffer
class with integer N
creates a Buffer
of length N
with raw (not "zero-ed") memory.
In the following example, the first call would allocate 100 bytes of memory, while the second example will allocate the memory needed for the string "100":
// uninitialized Buffer of length 100
x = new Buffer(100);
// initialized Buffer with value of '100'
x = new Buffer('100');
tunnel-agent
's request
construction uses the default Buffer
constructor as-is, making it easy to append uninitialized memory to an existing list. If the value of the buffer list is exposed to users, it may expose raw server side memory, potentially holding secrets, private data and code. This is a similar vulnerability to the infamous Heartbleed
flaw in OpenSSL.
Proof of concept by ChALkeR
require('request')({
method: 'GET',
uri: 'http://www.example.com',
tunnel: true,
proxy:{
protocol: 'http:',
host:"127.0.0.1",
port:8080,
auth:80
}
});
You can read more about the insecure Buffer
behavior on our blog.
Similar vulnerabilities were discovered in request, mongoose, ws and sequelize.
Remediation
Upgrade tunnel-agent
to version 0.6.0 or higher.
Note This is vulnerable only for Node <=4